Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Scala 2 syntax with -Xsource:3" warnings #3533

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 10, 2025

Since #3532 IntelliJ produced "Scala 2 syntax with -Xsource:3" warnings. This fixes them.

Since #3532 IntelliJ produced "Scala 2 syntax with -Xsource:3" warnings.
This fixes them.
@fthomas fthomas added this to the 0.32.2 milestone Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (c75d82f) to head (238a79d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3533   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files         171      171           
  Lines        4983     4984    +1     
  Branches      504      484   -20     
=======================================
+ Hits         4474     4475    +1     
  Misses        509      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you fix the manually ?
Can we define some scalafmt or scalafix rules so the are not coming back ?
OR some compiler flags, as we didn't had any warnings before (as far as I know)
Neither under Scala 2.13 nor Scala 3

Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

... so that wildcard imports are rewritten from `_` to `*`
@fthomas
Copy link
Member Author

fthomas commented Jan 10, 2025

Can we define some scalafmt or scalafix rules so the are not coming back ?

238a79d should do that.

@fthomas fthomas merged commit eae30d0 into main Jan 10, 2025
18 checks passed
@fthomas fthomas deleted the topic/more-scala-3-syntax branch January 10, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants