Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-circuit when reading mill-version files #3541

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 13, 2025

If a .mill-version exists there is no need to also read .config/mill-version and then discard its content.

If a `.mill-version` exists there is no need to also read
`.config/mill-version` and then discard its content.
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (26f9dd0) to head (ead762a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   89.77%   89.77%   -0.01%     
==========================================
  Files         171      171              
  Lines        4979     4977       -2     
  Branches      496      491       -5     
==========================================
- Hits         4470     4468       -2     
  Misses        509      509              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthomas fthomas merged commit 092736c into main Jan 13, 2025
18 checks passed
@fthomas fthomas deleted the topic/short-circuit-mill-version-reading branch January 13, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants