Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple default resolvers #3570

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 29, 2025

The default resolver - which is Maven Central if none is provided by the --default-maven-repo option - is now used in multiple places where a list of resolvers is expected. It feels like an arbitrary restriction that we only allow one resolver and always wrap that in a list everywhere we use it. Why not allow --default-maven-repo to be a repeating option instead so that Config has a List[Resolver]. This PR does exactly that. It could be useful if a user wants to resolve Scalafmt via resolver A and Gradle dependencies via resolver B for example.

@fthomas fthomas added the enhancement New feature or request label Jan 29, 2025
@fthomas fthomas added this to the 0.33.0 milestone Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (af9dad6) to head (958820e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/org/scalasteward/core/application/Cli.scala 80.00% 1 Missing ⚠️
...a/org/scalasteward/core/buildtool/sbt/SbtAlg.scala 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3570   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         174      174           
  Lines        5028     5029    +1     
  Branches      502      491   -11     
=======================================
+ Hits         4515     4516    +1     
  Misses        513      513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fthomas fthomas merged commit 3f58890 into main Jan 30, 2025
17 of 18 checks passed
@fthomas fthomas deleted the topic/multiple-default-resolvers branch January 30, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants