Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best-effort: fix compiler crash when using betasty with missing java classfiles #22599

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

jchyb
Copy link
Contributor

@jchyb jchyb commented Feb 13, 2025

Fixes the

exception occurred while extractSemanticDBExtractSemanticInfo /Users/tgodzik/Documents/dotty/compiler/test/dotty/tools/dotc/classpath/JrtClassPathTest.scala

  An unhandled exception was thrown in the compiler.
  Please file a crash report here:
  https://github.com/scala/scala3/issues/new/choose
  For non-enriched exceptions, compile with -Xno-enrich-error-messages.


     while compiling: /Users/tgodzik/Documents/dotty/compiler/test/dotty/tools/dotc/classpath/JrtClassPathTest.scala
        during phase: parser
                mode: Mode(ImplicitsEnabled,ReadPositions,SafeNulls)
     library version: version 2.13.16
    compiler version: version 3.6.4-RC1
            settings: -Wconf List(cat=deprecation&origin=scala\.collection\.mutable\.AnyRefMap.*:s) -Wsafe-init true -Xsemanticdb true -Ybest-effort true -Yexplicit-nulls true -Ywith-best-effort-tasty true -classpath /Users/tgodzik/Documents/dotty/compiler/

crash when best effort is used in the compiler on erroring code (where we lose access to java classifies)

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 482107b into scala:main Feb 13, 2025
29 checks passed
@SethTisue SethTisue deleted the fix-betasty-semanticdb branch February 13, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants