Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merging annotations with compressed fallback layers #1191

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

erjel
Copy link
Contributor

@erjel erjel commented Sep 9, 2024

Description:

If an annotation is merged with a compressed fallback layer, the bounding box of the output_mag needs to account for compressed shard writes outside the original bounding box beforehand. If the bounding box is not adapted accordingly prior to concurrent calls of merge_chunk, the merge operation will corrupt the target dataset properties and result in a JSONDecodeError.

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Updated Documentation -> not applicable
  • Added / Updated Tests
  • Considered adding this to the Examples -> not applicable

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution. Looks great!

@hotzenklotz hotzenklotz enabled auto-merge (squash) October 24, 2024 08:21
@hotzenklotz hotzenklotz merged commit 0fc495a into scalableminds:master Oct 24, 2024
19 checks passed
@erjel erjel deleted the fix_compressed_fallback_merge branch October 24, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants