Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix poetry install issues #899

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix poetry install issues #899

merged 2 commits into from
Apr 27, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Apr 25, 2023 •
edited
Loading

Description:

  • Updated our pyproject.toml files for wklibsand wkcuber to match the new build backend format poetry.core

Issues:

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Updated Documentation
  • Added / Updated Tests
  • Considered adding this to the Examples

@hotzenklotz hotzenklotz self-assigned this Apr 25, 2023
@hotzenklotz hotzenklotz requested a review from markbader April 25, 2023 13:17
markbader
markbader approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@markbader markbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the dependency installation with poetry version 1.4.2 and python 3.10.

Installation went through without any issues. 👍

@hotzenklotz hotzenklotz merged commit d36e0b0 into master Apr 27, 2023
@hotzenklotz hotzenklotz deleted the poetry-core branch April 27, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbader markbader markbader approved these changes

Assignees

@hotzenklotz hotzenklotz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotzenklotz @markbader