update zarrita, relaxes numpy requirement #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
normanrz
commented
Jul 31, 2023
normanrz
commented
- Updates zarrita, relaxes numpy requirement
markbader
reviewed
Aug 8, 2023
| @@ -867,6 +867,7 @@ def test_chunking_wk(data_format: DataFormat, output_path: Path) -> None: | |||
| ds_path = prepare_dataset_path(data_format, output_path) | |||
| ds = Dataset(ds_path, voxel_size=(2, 2, 1)) | |||
| chunk_shape, chunks_per_shard = default_chunk_config(data_format, 8) | |||
| shard_shape = chunk_shape * chunks_per_shard | |||
There was a problem hiding this comment.
I think the naming of shard_shape and chunk_shape is confusing. Why is the chunk_shape for initializing the mag different from the chunk_shape for iterating over the mag?
There was a problem hiding this comment.
Yes, that is a bit unfortunate. shard and chunk are the terms of the Zarr storage, but chunk is also used for the iterator functions. Do you have an idea how to resolve that?
markbader
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.