-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve speed of user list query #7466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to get that isEditableBy logic into SQL after all. Maybe add some comments to ensure we keep those in sync in the future. But 1 or n queries for n users will make a bigger difference for a longer user list (I assume you didn’t have more than 10 users when testing?)
Also, could you make use of ARRAY_AGG
and the parseArrayLiteral
function that was introduced in #7479 ? (Also for the other recently added compact queries). Then we don’t have this null
able handling code with Option(x)
distributed all over our codebase.
URL of deployed dev instance (used for testing):
For the two test users this results in about 30% faster requests for me.
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)