-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr streaming e2e test #8137
base: master
Are you sure you want to change the base?
Zarr streaming e2e test #8137
Changes from all commits
c276a20
26dafe7
8fb12a1
0968608
2d6065a
b6ee187
9323568
4a09bf6
01f4c60
6309c9b
88f9feb
ee0b7c3
459ff77
152acca
1d72230
8034308
595701e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ const volatileKeys: Array<string | number | symbol> = [ | |
"lastActivity", | ||
"tracingTime", | ||
"tracingId", | ||
"sortingKey", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Snapshots need to be updated due to "sortingKey" changes The codebase contains snapshot files that reference "sortingKey", specifically in
🔗 Analysis chainVerify snapshot recomputation after adding "sortingKey". The addition of "sortingKey" to volatileKeys is appropriate. As per the comment above the array, snapshots need to be recomputed when this array is modified. Run the following script to check if there are any snapshot files that need updating: Let me check the content of these snapshot files to see if they contain any instances of "sortingKey" that might be affected. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for snapshot files that might need updating
# Look for snapshot files in the test directory
fd -e snap -e snapshot . frontend/javascripts/test
Length of output: 1460 Script: #!/bin/bash
# Search for "sortingKey" in snapshot files to understand the impact
rg "sortingKey" frontend/javascripts/test/snapshots/
Length of output: 193 |
||
]; | ||
export function replaceVolatileValues(obj: ArbitraryObject | null | undefined) { | ||
if (obj == null) return obj; | ||
|
@@ -130,7 +131,7 @@ export async function writeTypeCheckingFile( | |
const fullTypeAnnotation = options.isArray ? `Array<${typeString}>` : typeString; | ||
fs.writeFileSync( | ||
`frontend/javascripts/test/snapshots/type-check/test-type-checking-${name}.ts`, | ||
` | ||
` | ||
import type { ${typeString} } from "types/api_flow_types"; | ||
const a: ${fullTypeAnnotation} = ${JSON.stringify(object)}`, | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling for fetch requests
While the test implementation is good, it should handle potential network failures or invalid responses.
Consider adding error handling:
📝 Committable suggestion