chore: Remove verbose option otherwise it's always verbose #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpodsiad
approved these changes
Jul 17, 2023
ckipp01
approved these changes
Jul 18, 2023
adpi2
approved these changes
Jul 18, 2023
filipwiech
reviewed
Jul 18, 2023
| @@ -78,7 +78,7 @@ final class BspBridge( | |||
| bspServerStatus = Some { | |||
| bspCmd.mkString(" ") -> { | |||
| // Make it verbose so that bsp preparation logs are emitted | |||
There was a problem hiding this comment.
This comment seems no longer valid? 🙂
There was a problem hiding this comment.
It's not, thanks! I removed it
It seems because we add an option to log verbose option to BSP, now it's always doing it, since verbose is specified at the start. I changed that in order to be able to specify verbose on demand for compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems because we add an option to log verbose option to BSP, now it's always doing it, since verbose is specified at the start. I changed that in order to be able to specify verbose on demand for compile.
It doesn't seem like it's needed currently, since the initial logs are printed to output stream set in the launcher.