Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Try to stop bloop if unable to run about #2421

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 6, 2024

This was raised on discord and it seems when we fail to parse the output of about everything will break.

This is because there is a server running and we will not restart it and the output of about command will again we wrong when we reask.

Now, we should try to exit it first in that case since msot likely the server is broken.

This was raised on discord and it seems when we fail to parse the output of `about` everything will break.

This is because there is a server running and we will not restart it and the output of about command will again we wrong when we reask.

Now, we should try to exit it first in that case since msot likely the server is broken.
@tgodzik tgodzik requested a review from adpi2 September 6, 2024 14:52
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit c6630f1 into scalacenter:main Sep 9, 2024
17 checks passed
@tgodzik tgodzik deleted the dont-retry branch September 9, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants