Fix CI job on main for 3.5+ #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Jul 24, 2024
|
The failure looks flaky, so I will go ahead and merge |
adpi2
reviewed
Jul 31, 2024
| @@ -27,28 +27,32 @@ jobs: | |||
| publish: | |||
| if: startsWith(github.ref, 'refs/tags/v') | |||
| runs-on: ubuntu-latest | |||
| needs: [test] | |||
There was a problem hiding this comment.
I think we should remove this. In a new Scala 3 version it is likely that some evaluation tests fail but we still want to release the expression compiler and fix the evaluation on main.
There was a problem hiding this comment.
Compilation will be tested anyway in publish step, so any binary incompatibilities will be found. If you think that this is enough, let's remove this
adpi2
added a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.