Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI status badge #1801

Merged
merged 2 commits into from
May 30, 2024
Merged

Remove CI status badge #1801

merged 2 commits into from
May 30, 2024

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented May 29, 2024

Description

This removes the badge from the readme, showing the CI status for the master branch.

The badge was not working anymore since we stopped running the CI when commit were pushed to the master branch. This started a discussion about its usefulness, and we decided to remove it since showing the CI status of a development branch does not seem relevant.

Related issues and/or PRs

N/A

Changes made

Remove the CI status badge from the readme

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@Torch3333 Torch3333 self-assigned this May 29, 2024
@Torch3333 Torch3333 marked this pull request as ready for review May 29, 2024 01:47
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brfrn169 brfrn169 merged commit 274d4c7 into master May 30, 2024
25 checks passed
@brfrn169 brfrn169 deleted the remove-ci-status-badge branch May 30, 2024 02:21
feeblefakie pushed a commit that referenced this pull request May 30, 2024
feeblefakie pushed a commit that referenced this pull request May 30, 2024
feeblefakie pushed a commit that referenced this pull request May 30, 2024
feeblefakie pushed a commit that referenced this pull request May 30, 2024
feeblefakie pushed a commit that referenced this pull request May 30, 2024
feeblefakie pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants