Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eclipse-temurin base image in Dockerfile #1826

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

kota2and3kan
Copy link
Contributor

Description

This PR updates the base image in the Dockerfile from ghcr.io/scalar-labs/jre8 to eclipse-temurin.

Basically, this PR updates the same things in https://github.com/scalar-labs/scalardb-cluster/pull/542.

Please take a look!

Related issues and/or PRs

Changes made

  • Update base image from ghcr.io/scalar-labs/jre8 to eclipse-temurin.
  • Remove unnecessary configuration from .github/dependabot.yml.
  • Update the version of the hadolint command.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Update base image of container image. This update fixes an OOM issue on a Kubernetes with cgroup v2 environment. In the previous versions, if you use a Kubernetes cluster with cgroup v2, you might face an OOM-killed issue.

@kota2and3kan kota2and3kan requested a review from a team May 31, 2024 10:00
@kota2and3kan kota2and3kan self-assigned this May 31, 2024
@kota2and3kan kota2and3kan requested review from komamitsu, brfrn169, feeblefakie and Torch3333 and removed request for a team May 31, 2024 10:00
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants