-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert behavior : the Gradle build does not require to use JDK 8 (temurin) #1837
Conversation
ca93b65
to
1a8fa57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for quickly fixing it. I was able to confirm the behavior reverted in my environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@Torch3333 The Cosmos DB integration test is failing. Can you check? |
@feeblefakie CI passed by retrying it since it was an out-of-memory error. So, I think we can merge this. (If the same issue occurs a lot, we might need to consider something, though.)
|
@jnmt Thank you! |
@jnmt I noticed CosmosDB integration tests have been particularly flaky recently. |
Description
Changes introduced by #1749 made the Gradle build require having a JDK 8 (temurin) installed on the system. This forced users cloning ScalarDB repository and using the master branch to have installed JDK 8 (temurin), which is inconvenient.
This PR reverts to the previous behavior, which is not to force Gradle to use a specific JDK. Users can use any JDK they desire to build ScalarDB.
Additionally, #1749 added Gradle project properties to configure Gradle to use a specific JDK version and vendor. This is left unchanged.
Related issues and/or PRs
Changes made
Updated
JdkConfigurationPlugin
to not require Java-related tasks to use JDK 8 (temurin). Java-related tasks will used by default the JDK used by Gradle.Checklist
Additional notes (optional)
N/A
Release notes
N/A