-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default value of metadata cache expiration time #2274
Change default value of metadata cache expiration time #2274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you! I think this could reduce a chance that developer's face troubles when they change the schema in short term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯 💯 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@Torch3333 I'll merge this. Please take a look when you are back. |
Description
This PR changes the default value of the metadata cache expiration time (
scalar.db.metadata.cache_expiration_time_secs
) to 60 seconds. Strictly speaking, this may be an incompatible change, but I don't expect it to cause any problems. If there are any objections, please let me know.Related issues and/or PRs
N/A
Changes made
scalar.db.metadata.cache_expiration_time_secs
) to 60 seconds.Checklist
Additional notes (optional)
N/A
Release notes
Changed the default value of the metadata cache expiration time (
scalar.db.metadata.cache_expiration_time_secs
) to 60 seconds.