Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of metadata cache expiration time #2274

Merged

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Oct 8, 2024

Description

This PR changes the default value of the metadata cache expiration time (scalar.db.metadata.cache_expiration_time_secs) to 60 seconds. Strictly speaking, this may be an incompatible change, but I don't expect it to cause any problems. If there are any objections, please let me know.

Related issues and/or PRs

N/A

Changes made

  • Changed the default value of the metadata cache expiration time (scalar.db.metadata.cache_expiration_time_secs) to 60 seconds.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Changed the default value of the metadata cache expiration time (scalar.db.metadata.cache_expiration_time_secs) to 60 seconds.

Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! I think this could reduce a chance that developer's face troubles when they change the schema in short term.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 💯 💯

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169
Copy link
Collaborator Author

@Torch3333 I'll merge this. Please take a look when you are back.

@brfrn169 brfrn169 merged commit d3251d3 into master Oct 10, 2024
46 checks passed
@brfrn169 brfrn169 deleted the change-default-value-of-metadata-cache-expiration-time branch October 10, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants