Use git+https:// for pip installation in Dockerfiles

[benblamey]

(git:// is no longer supported)

[benblamey]

Tested both Dockerfiles, looks happy:

 => [2/5] COPY requirements.txt /app/                                                                                                                                                           0.2s
 => [3/5] WORKDIR /app                                                                                                                                                                          0.0s
 => [4/5] RUN pip install -r requirements.txt                                                                                                                                                 128.4s
 => [5/5] RUN pip install -e git+https://github.com/scaleoutsystems/fedn.git@develop#egg=fedn&subdirectory=fedn                                                                               137.7s
 => exporting to image                                                                                                                                                                         58.5s
 => => exporting layers    

This was the error:

 => ERROR [2/2] RUN pip install -e https://github.com/scaleoutsystems/fedn.git#egg=fedn&subdirectory=fedn                                                                                       3.2s
------                                                                                                                                                                                               
 > [2/2] RUN pip install -e https://github.com/scaleoutsystems/fedn.git#egg=fedn&subdirectory=fedn:                                                                                                  
#6 2.779 ERROR: https://github.com/scaleoutsystems/fedn.git#egg=fedn&subdirectory=fedn is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with bzr+http, bzr+https, bzr+ssh, bzr+sftp, bzr+ftp, bzr+lp, bzr+file, git+http, git+https, git+ssh, git+git, git+file, hg+file, hg+http, hg+https, hg+ssh, hg+static-http, svn+ssh, svn+http, svn+https, svn+svn, svn+file).                                                                                                                                                                               
#6 3.060 WARNING: You are using pip version 21.1.1; however, version 22.0.4 is available.
#6 3.060 You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
------
executor failed running [/bin/sh -c pip install -e https://github.com/scaleoutsystems/fedn.git#egg=fedn\&subdirectory=fedn]: exit code: 1

Using git+git:// gives this error:

 => ERROR [5/5] RUN pip install -e git+git://github.com/scaleoutsystems/fedn.git@develop#egg=fedn&subdirectory=fedn                                                                             2.4s
------                                                                                                                                                                                               
 > [5/5] RUN pip install -e git+git://github.com/scaleoutsystems/fedn.git@develop#egg=fedn&subdirectory=fedn:                                                                                        
#8 1.833 Obtaining fedn from git+git://github.com/scaleoutsystems/fedn.git@develop#egg=fedn&subdirectory=fedn                                                                                        
#8 1.834   Cloning git://github.com/scaleoutsystems/fedn.git (to revision develop) to ./src/fedn                                                                                                     
#8 1.835   Running command git clone -q git://github.com/scaleoutsystems/fedn.git /app/src/fedn                                                                                                      
#8 2.178   fatal: remote error:                                                                                                                                                                      
#8 2.178     The unauthenticated git protocol on port 9418 is no longer supported.
#8 2.178   Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
#8 2.181 WARNING: Discarding git+git://github.com/scaleoutsystems/fedn.git@develop#egg=fedn&subdirectory=fedn. Command errored out with exit status 128: git clone -q git://github.com/scaleoutsystems/fedn.git /app/src/fedn Check the logs for full command output.
#8 2.331 ERROR: Could not find a version that satisfies the requirement fedn (unavailable) (from versions: 0.2.5.dev0)
#8 2.332 ERROR: No matching distribution found for fedn (unavailable)
#8 2.342 WARNING: You are using pip version 21.1.1; however, version 22.0.4 is available.
#8 2.342 You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
------