Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Update dependencies for imdb example #34

Closed
wants to merge 1 commit into from

Conversation

benblamey
Copy link
Contributor

This is verbatim from Addi's code on Slack.
I have tested that it builds. It takes 300 seconds to build, and versions of numpy are installed, then uninstalled.

[+] Building 300.6s (12/12) FINISHED                                                                                                                                                                              
 => [internal] load build definition from Dockerfile                                                                                                                                                         0.0s
 => => transferring dockerfile: 271B                                                                                                                                                                         0.0s
 => [internal] load .dockerignore                                                                                                                                                                            0.0s
 => => transferring context: 2B                                                                                                                                                                              0.0s
 => [internal] load metadata for docker.io/library/python:3.8.9                                                                                                                                              2.0s
 => [auth] library/python:pull token for registry-1.docker.io                                                                                                                                                0.0s
 => [internal] load build context                                                                                                                                                                            0.0s
 => => transferring context: 85B                                                                                                                                                                             0.0s
 => CACHED [1/6] FROM docker.io/library/python:3.8.9@sha256:49d05fff9cb3b185b15ffd92d8e6bd61c20aa916133dca2e3dbe0215270faf53                                                                                 0.0s
 => [2/6] COPY requirements.txt /app/                                                                                                                                                                        0.0s
 => [3/6] WORKDIR /app                                                                                                                                                                                       0.0s
 => [4/6] RUN pip install -r requirements.txt                                                                                                                                                              153.0s
 => [5/6] RUN pip install -e git+https://github.com/scaleoutsystems/fedn.git@develop#egg=fedn&subdirectory=fedn                                                                                            116.0s
 => [6/6] RUN pip install numpy==1.19.5                                                                                                                                                                      6.1s 
 => exporting to image                                                                                                                                                                                      23.3s 
 => => exporting layers                                                                                                                                                                                     23.3s 
 => => writing image sha256:dd5d61c5fe0252dc5de0adce21051fb86de93ee733fedeb199321080e404e8b4                                                                                                                 0.0s 
                                                                                                                                                                                                                  
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them                `

@@ -2,4 +2,5 @@ FROM python:3.8.9
COPY requirements.txt /app/
WORKDIR /app
RUN pip install -r requirements.txt
RUN pip install -e git+https://github.com/scaleoutsystems/fedn.git#egg=fedn\&subdirectory=fedn
RUN pip install -e git+https://github.com/scaleoutsystems/fedn.git@develop#egg=fedn\&subdirectory=fedn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the need to change the install to develop instead of main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I can't test fedn on my own machine anyway because of this issue:
scaleoutsystems/fedn#393

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make an effort to support 3.10 native. But in the meantime, did you see that we have a vscode devcontainer and also a docker-compose that will bring it up?

@ahellander
Copy link
Member

Closing since fedn supports 3.10 since 0.3.3

@ahellander ahellander closed this Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants