Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onchange and border #4652

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: onchange and border #4652

wants to merge 4 commits into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Jan 9, 2025

Summary

Type

  • Bug
  • Enhancement

Summarise concisely:

What is expected?

<SelectInputV2 />:

  • onChange handle on checkboxes fix
  • visual indication of focused item for keyboard users (if the element was already selected, it was not possible to see that the element had focus)
  • no automatic scroll when using "enter" to select an item

Relevant logs and/or screenshots

Before ("Venus" has focus) :
Capture d’écran 2025-01-09 à 15 41 29

After (when navigating with keyboard) :
Capture d’écran 2025-01-09 à 15 40 30

@lisalupi lisalupi self-assigned this Jan 9, 2025
@lisalupi lisalupi requested review from johnrazeur, a team and matthprost as code owners January 9, 2025 14:45
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 8f0cad9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (9db9273) to head (8f0cad9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 0.00% 10 Missing ⚠️
...src/components/SelectInputV2/SearchBarDropdown.tsx 0.00% 2 Missing ⚠️
...ages/ui/src/components/SelectInputV2/SelectBar.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4652      +/-   ##
==========================================
- Coverage   87.65%   87.60%   -0.05%     
==========================================
  Files         341      341              
  Lines       12899    12925      +26     
  Branches     3519     3575      +56     
==========================================
+ Hits        11306    11323      +17     
- Misses       1593     1602       +9     
Files with missing lines Coverage Δ
...src/components/SelectInputV2/SearchBarDropdown.tsx 6.49% <0.00%> (-0.18%) ⬇️
...ages/ui/src/components/SelectInputV2/SelectBar.tsx 63.57% <0.00%> (-0.93%) ⬇️
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 41.39% <0.00%> (-1.42%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a90434...8f0cad9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants