Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(VerificationCode): implement norm of inputs #4673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Refactor

Summarise concisely:

What is expected?

Refactor VerificationCode and VerificationCodeField to follow the same props are new inputs.

Relevant logs and/or screenshots

Screenshot 2025-01-16 at 16 40 20
Screenshot 2025-01-16 at 16 40 25
Screenshot 2025-01-16 at 16 40 31

@matthprost matthprost added the refactor Refactor without breaking changes label Jan 16, 2025
@matthprost matthprost self-assigned this Jan 16, 2025
@matthprost matthprost requested review from johnrazeur, a team and lisalupi as code owners January 16, 2025 15:40
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 59deb16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 89.04110% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (b4b5366) to head (59deb16).

Files with missing lines Patch % Lines
...orm/src/components/VerificationCodeField/index.tsx 16.66% 5 Missing ⚠️
...kages/ui/src/components/VerificationCode/index.tsx 93.47% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4673      +/-   ##
==========================================
+ Coverage   88.09%   88.12%   +0.03%     
==========================================
  Files         348      348              
  Lines       13363    13402      +39     
  Branches     3638     3694      +56     
==========================================
+ Hits        11772    11811      +39     
  Misses       1591     1591              
Files with missing lines Coverage Δ
...mponents/VerificationCode/__tests__/index.test.tsx 100.00% <100.00%> (ø)
...kages/ui/src/components/VerificationCode/index.tsx 98.19% <93.47%> (-1.81%) ⬇️
...orm/src/components/VerificationCodeField/index.tsx 47.05% <16.66%> (+4.20%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b5366...59deb16. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants