Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): new icons and better deprecated management #4823

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Feb 27, 2025

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

I've added a better deprecated management in for icons. We now have a file that contains all deprecated icons and based on that file we will generate JSDoc comment for those icons. Storybook will also follow that file to show (or not) if an icon is deprecated.

Screenshot 2025-02-27 at 15 24 36

I also added documentation on each icon types (product, category and system) to explain how to deprecate an icon.

Screenshot 2025-02-27 at 15 30 08

In addition I made those updates:

  • New icons <ListNumberIcon />, <ListBulletIcon />, <ItalicIcon />, <BoldIcon />, <UnderlineIcon />, <MongoDbProductIcon />, <VpnProductIcon /> and <WafProductIcon />.
  • <DocumentDbProductIcon /> is now deprecated and should be replaced by <MongoDbProductIcon />.
  • <AsteriskIcon /> is now deprecated and should be replaced by the letter * from fonts.
  • <CrossCircleIcon /> is now deprecated and should be replaced by <CloseCircleOutlineIcon />.
  • <CrossCircleOutlineIcon /> is now deprecated and should be replaced by <CloseCircleOutlineIcon />.
  • <DragVariantIcon /> is now deprecated and should be replaced by <DragIcon />.

@matthprost matthprost requested a review from a team February 27, 2025 15:01
@matthprost matthprost self-assigned this Feb 27, 2025
@matthprost matthprost requested a review from lisalupi as a code owner February 27, 2025 15:01
@matthprost matthprost requested review from vincentaudebert and fabienhebert and removed request for a team February 27, 2025 15:01
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: b4a7876

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/icons Minor
@ultraviolet/plus Patch
@ultraviolet/ui Patch
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (4a0a1fb) to head (b4a7876).
Report is 31 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4823   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         230      230           
  Lines        8013     8013           
  Branches     3631     3631           
=======================================
  Hits         7149     7149           
  Misses        864      864           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8543e...b4a7876. Read the comment docs.

@matthprost matthprost merged commit b160d8f into main Mar 4, 2025
29 checks passed
@matthprost matthprost deleted the feat/new-icons branch March 4, 2025 10:45
@scaleway-bot scaleway-bot mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants