Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): add disabled prop on button cancel #4828

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

  • Add disabled prop on <Dialog.CancelButton />
  • Rename folder subComponent into components to be consistent with other components

@matthprost matthprost added the refactor Refactor without breaking changes label Feb 28, 2025
@matthprost matthprost self-assigned this Feb 28, 2025
@matthprost matthprost requested a review from lisalupi as a code owner February 28, 2025 10:22
Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: a0262a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (4a0a1fb) to head (a0262a9).
Report is 31 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4828   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         230      230           
  Lines        8013     8013           
  Branches     3631     3631           
=======================================
  Hits         7149     7149           
  Misses        864      864           
Files with missing lines Coverage Δ
...ges/ui/src/components/Dialog/components/Button.tsx 25.00% <ø> (ø)
...es/ui/src/components/Dialog/components/Buttons.tsx 100.00% <ø> (ø)
.../src/components/Dialog/components/CancelButton.tsx 100.00% <100.00%> (ø)
...ages/ui/src/components/Dialog/components/Stack.tsx 100.00% <ø> (ø)
...kages/ui/src/components/Dialog/components/Text.tsx 100.00% <ø> (ø)
packages/ui/src/components/Dialog/index.tsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ff54c...a0262a9. Read the comment docs.

@matthprost matthprost merged commit e2b112c into main Mar 4, 2025
16 checks passed
@matthprost matthprost deleted the fix/dialog-buttons branch March 4, 2025 10:46
@scaleway-bot scaleway-bot mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants