srfi/125.sld: conform "rename" clause to r6rs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused. The code you're updating uses the R7RS |
|
Excuse me for the late reply. Well. Now I am also confused. Maybe I am wrong. Came to this conclusion in 2 steps:
Syntax error:
unknown location: source expression failed to match any pattern in form ((rename deprecated:hash hash) (rename deprecated:string-hash string-hash) (rename deprecated:string-ci-hash string-ci-hash) (rename deprecated:hash-by-identity hash-by-identity) (rename deprecated:hash-table-equivalence-function hash-table-equivalence-function) (rename deprecated:hash-table-hash-function hash-table-hash-function) (rename deprecated:hash-table-exists? hash-table-exists?) (rename deprecated:hash-table-walk hash-table-walk) (rename deprecated:hash-table-merge! hash-table-merge!))even with
|
|
On Tue, May 28, 2024 at 10:41 AM Grigory Shepelev ***@***.***> wrote:
Well. Now I am also confused. Maybe I am wrong. Came to this conclusion in
2 steps:
1. Reading R6RS
2. Trying to pack srfi-125 into guix
<https://gist.github.com/shegeley/d42e737b7d758c3ec7fb6e9918abe81b>
and encountering this error:
As far as I understand, Guile supports its own modules and R6RS libraries
<https://www.gnu.org/software/guile/manual/html_node/R6RS-Libraries.html>,
but not R7RS libraries. The sample implementation of SRFI 125 is written
using the R7RS define-library form, which is incompatible, but almost the
same. (Yes, I know. There were good reasons for the changes, but the
results are not ideal. I'm hoping that R7RS Large will get us closer.)
So the solution is what you've done for your own copy defined using library
(not define-library). But since the copy in the SRFI repo is defined using
define-library, it should not be updated.
Thanks for the contribution.
… Message ID:
***@***.***
com>
|
|
Thanks for the clarification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "rename" clause was broken. Wouldn't work in guile scheme and I think it's just doesn't conform to r6rs.
Fix introduced.