Skip to content

Commit

Permalink
patching find_package call
Browse files Browse the repository at this point in the history
  • Loading branch information
KevKeating committed Feb 26, 2025
1 parent 846509f commit 6684810
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
4 changes: 2 additions & 2 deletions external/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ ExternalProject_Add(
GIT_SHALLOW TRUE
USES_TERMINAL_CONFIGURE ON
USES_TERMINAL_BUILD ON
PATCH_COMMAND git apply ${CMAKE_CURRENT_SOURCE_DIR}/rdkit.patch
UPDATE_DISCONNECTED 1 # required to not apply patch again once populated
PATCH_COMMAND git reset --hard HEAD && git apply ${CMAKE_CURRENT_SOURCE_DIR}/rdkit_static_build.patch && git apply ${CMAKE_CURRENT_SOURCE_DIR}/rdkit_find_boost.patch
# UPDATE_DISCONNECTED 1 # required to not apply patch again once populated
CMAKE_ARGS
${COMMON_EXTERNAL_PROJECT_CMAKE_ARGS}
-DCMAKE_INSTALL_PREFIX=${CMAKE_CURRENT_BINARY_DIR}/rdkit-${RDKIT_VERSION}
Expand Down
File renamed without changes.
13 changes: 13 additions & 0 deletions external/rdkit_wasm_find_boost.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1abad9260..ae1938dd6 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -308,7 +308,7 @@ if(RDK_BUILD_PYTHON_WRAPPERS)
endif()


- find_package(Boost ${RDK_BOOST_VERSION} COMPONENTS "python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}" "numpy${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}" REQUIRED CONFIG)
+ find_package(Boost ${RDK_BOOST_VERSION} COMPONENTS "python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}" "numpy${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}" REQUIRED CONFIG NO_CMAKE_FIND_ROOT_PATH)

target_link_libraries(rdkit_py_base INTERFACE "Boost::python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}" "Boost::numpy${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}")

0 comments on commit 6684810

Please sign in to comment.