Skip to content

Commit

Permalink
Change discussion link to point to comments at bottom of SPEC (#724)
Browse files Browse the repository at this point in the history
In accordance with scientific-python/specs#369
  • Loading branch information
stefanv authored Feb 3, 2025
1 parent 36d717d commit 91e1ca0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions layouts/partials/specs/spec_meta.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@

{{/* Create field list */}}
{{- $fieldList := slice -}}
{{- range $term := slice "author" "discussion" "history" "endorsed-by" -}}
{{- range $term := slice "author" "history" "endorsed-by" -}}
{{- $def := index $.Params $term }}
{{- if eq $term "author" }}
{{- $term = "authors" }}
{{- if not (reflect.IsSlice $def) }}
{{- $def = slice $def }}
{{- end }}
{{- $def = delimit $def ", " }}
{{- else if (eq $term "discussion") }}
{{- $def = $def | markdownify }}
{{- else if (eq $term "history") }}
{{- $def = printf "https://github.com/scientific-python/specs/commits/main/%s" $filename | markdownify }}
{{- else if and (eq $term "endorsed-by") (reflect.IsSlice $def) }}
Expand All @@ -25,6 +23,7 @@
{{- end }}
{{- $fieldList = $fieldList | append (dict "term" ( $term | humanize ) "def" $def ) -}}
{{- end -}}
{{ $fieldList = $fieldList | append (dict "term" "Discussion" "def" ("[Comments below](#discourse-comments)" | markdownify)) }}
{{- $specMetaBody := partial "_elements/field-list.html" (dict "entries" $fieldList) -}}

{{/* Add draft warning */}}
Expand Down

0 comments on commit 91e1ca0

Please sign in to comment.