-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: if.scikit-build-version #851
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
The plain |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 74 74
Lines 4347 4361 +14
=======================================
+ Hits 3646 3658 +12
- Misses 701 703 +2 ☔ View full report in Codecov by Sentry. |
I was trying to match Admittedly, |
Would |
|
☝️ Length wise I think it's fine as it will always be in its own block with only
👍. Not much longer than |
Signed-off-by: Henry Schreiner <[email protected]>
This adds an
if.scikit-build-version
, and makes sure it can be used to gate features not yet implemented. This should help with #769 by providing a way to support old scikit-build-core's on Python 3.7 even after we drop support.Also fixes auto minimum-version to respect markers.