Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Disable RNTuple tests for now and unpin selenium version #1334

Merged
merged 3 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ test = [
]
test-pyodide = [
"pytest>=6",
"selenium<=4.25.0", # unpin once >4.26.0 is available
ariostas marked this conversation as resolved.
Show resolved Hide resolved
"pytest-pyodide",
"pytest-timeout",
"scikit-hep-testdata"
Expand Down
3 changes: 3 additions & 0 deletions tests-wasm/test_1272_basic_functionality.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def test_write_ttree(selenium):


# Taken from test_1191_rntuple_fixes.py
@pytest.mark.skip(reason="Skipping until test files are available with RNTuple v1.0")
@run_test_in_pyodide(test_file="test_ntuple_extension_columns.root")
def test_read_rntuple(selenium):
import uproot
Expand All @@ -95,6 +96,7 @@ def test_read_rntuple(selenium):


# Taken from test_0034_generic_objects_in_ttrees.py
@pytest.mark.skip(reason="Skipping until test files are available with RNTuple v1.0")
@pytest.mark.network
@run_test_in_pyodide(packages=["requests"])
def test_read_ttree_http(selenium):
Expand All @@ -116,6 +118,7 @@ def test_read_ttree_http(selenium):


# Taken from test_1191_rntuple_fixes.py
@pytest.mark.skip(reason="Skipping until test files are available with RNTuple v1.0")
@pytest.mark.network
@run_test_in_pyodide(packages=["requests"])
def test_read_rntuple_http(selenium):
Expand Down
4 changes: 4 additions & 0 deletions tests/test_0013_rntuple_anchor.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@

import uproot

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test():
filename = skhep_testdata.data_path("uproot-ntpl001_staff.root")
Expand Down
4 changes: 4 additions & 0 deletions tests/test_0630_rntuple_basics.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

pytest.importorskip("awkward")

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test_flat():
filename = skhep_testdata.data_path("test_ntuple_int_float.root")
Expand Down
4 changes: 4 additions & 0 deletions tests/test_0662_rntuple_stl_containers.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

ak = pytest.importorskip("awkward")

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test_rntuple_stl_containers():
filename = skhep_testdata.data_path("test_ntuple_stl_containers.root")
Expand Down
4 changes: 4 additions & 0 deletions tests/test_0705_rntuple_writing_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@

ak = pytest.importorskip("awkward")

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


@pytest.mark.skip(
reason="RNTuple writing is pending until specification 1.0.0 is released."
Expand Down
4 changes: 4 additions & 0 deletions tests/test_0962_RNTuple_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
import skhep_testdata
import numpy as np

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test_new_support_RNTuple_split_int32_reading():
with uproot.open(skhep_testdata.data_path("test_ntuple_int_5e4.root")) as f:
Expand Down
4 changes: 4 additions & 0 deletions tests/test_1191_rntuple_fixes.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@

import uproot

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test_schema_extension():
filename = skhep_testdata.data_path("test_ntuple_extension_columns.root")
Expand Down
4 changes: 4 additions & 0 deletions tests/test_1223_more_rntuple_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@

import uproot

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test_atomic():
filename = skhep_testdata.data_path("test_ntuple_atomic_bitset.root")
Expand Down
4 changes: 4 additions & 0 deletions tests/test_1250_rntuple_improvements.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@

import uproot

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test_field_class():
filename = skhep_testdata.data_path("DAOD_TRUTH3_RC2.root")
Expand Down
6 changes: 6 additions & 0 deletions tests/test_1285_rntuple_multicluster_concatenation.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@

import uproot

import pytest

pytest.skip(
"Skipping until test files are available with RNTuple v1.0", allow_module_level=True
)


def test_schema_extension():
filename = skhep_testdata.data_path("test_ntuple_index_multicluster.root")
Expand Down
Loading