New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dps management #248

Open

EmmaRenauld wants to merge 4 commits into scil-vital:master from EmmaRenauld:dps_in_config_file

Collaborator

EmmaRenauld commented Oct 9, 2024

Started adding tests

Changed dps from an arg in the script (--dps_keys) to a line in the config file. This works.
Copied the file streamline_containers from Jeremi's PR and started testing. Does not seem to work yet. Need to check the data shape. Work to be continued.

EmmaRenauld and others added 4 commits

October 9, 2024 15:55


          Changed dps option from parser to config file

1a5656e


          Add dps to the streamline_containers (Jeremi's work)

1360e58


          WIP. Adding tests. Error data_per_streamline's shape not understood!

ca2161c


          Fix dps tests

ee60a2f

Collaborator

levje commented Oct 11, 2024

Not to forget: maybe worth adding tests for 2D data_per_streamline arrays before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet