Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointer #754

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix pointer #754

merged 2 commits into from
Nov 21, 2023

Conversation

Joao-Dionisio
Copy link
Collaborator

Fix #753

Thanks for the help, @lperron! I'm still new to this stuff, so I appreciate it.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4633ad8) 62.02% compared to head (e9f8623) 62.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   62.02%   62.04%   +0.01%     
==========================================
  Files          16       16              
  Lines        3163     3164       +1     
==========================================
+ Hits         1962     1963       +1     
  Misses       1201     1201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lperron
Copy link

lperron commented Nov 21, 2023

I cannot approve it :-) But it looks good.

Copy link
Member

@mmghannam mmghannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/pyscipopt/scip.pxi Show resolved Hide resolved
@mmghannam mmghannam merged commit e9a242e into master Nov 21, 2023
3 checks passed
@Joao-Dionisio Joao-Dionisio deleted the issue-753 branch November 21, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong argument to sizeof: should be sizeof(SCIP_VAR*)
3 participants