Update Model._modelvars before freeTransfrom #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @igorbanfi, thank you for your contribution! Would be great if you could also add a test with the code that was failing in #755. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 62.04% 62.12% +0.07%
==========================================
Files 16 16
Lines 3164 3168 +4
==========================================
+ Hits 1963 1968 +5
+ Misses 1201 1200 -1 ☔ View full report in Codecov by Sentry. |
|
For help with writing a test, see Issue #739, @igorbanfi. If it's too much of a hassle, we can also do it ourselves, of course, but it's nicer if it's just one author :) |
mmghannam
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before running freeTransform nonOriginal variables are removed from _modelvars.
fix for #755