Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty doctests, stop blank filtering DeprecationWarnings #124

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Feb 22, 2024

  • Put back the skip of docstrings with no doctest examples: pytest does it, and there is no reason not to. If we don't skip them here, pytest --doctest-modules reports them as if they had +SKIP anyway.
  • Stop filtering all DeprecationWarnings. This was a temp filter IIUC, and this is bad practice in general. Either rewrite the docstring to avoid deprecated stuff, or use a more granular filter in dt_context.user_context_mgr.

@Sheila-nk
Copy link
Collaborator

This seems pretty straightforward. Feel free to merge @ev-br 🥳

@ev-br ev-br merged commit 1582d03 into main Feb 23, 2024
4 checks passed
@ev-br ev-br deleted the skip_empty branch February 23, 2024 10:58
@ev-br
Copy link
Member Author

ev-br commented Feb 23, 2024

Thanks Sheila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants