BUG: special: Fix typo in specfun::chgu #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkydragon
commented
Jan 3, 2025
Comment on lines
894
to
901
| if (b <= a) { | ||
| b00 = b; | ||
| a -= b - 1.0; | ||
| b = 2.0 - b; | ||
| hu = chguit(x, a, b, &id); | ||
| hu *= pow(x, 1.0 - b); | ||
| hu *= pow(x, 1.0 - b00); | ||
| *md = 4; | ||
| } else if (bn && (~il1)) { |
There was a problem hiding this comment.
Here we want to use the unmodified b.
IF (B.LE.A) THEN
A00=A
B00=B ! ........... save B, B00 <- B
A=A-B+1.0D0
B=2.0D0-B ! ........... modify B, B <- 2 - B
CALL CHGUIT(A,B,X,HU,ID)
HU=X**(1.0D0-B00)*HU ! use unmodified B00
A=A00
B=B00
MD=4
ELSE IF (BN.AND.(.NOT.IL1)) THEN
CALL CHGUBI(A,B,X,HU,ID)
MD=3
ENDIF
|
Thanks @inkydragon. I appreciate your help finding issues like this. Until we finish getting CI set up, I don't think we can merge this and your other PR, but you can make PRs to SciPy if you like. I found that it's pretty straightforward to cherry pick commits over (it helps if there aren't any commits that touch both the xsf folder in SciPy and something outside of it). Or we can leave these open until CI is ready (hopefully this week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/scipy/scipy/blob/9d08eb58205fb669ff72c60080b18be61b14d8e1/scipy/special/specfun/specfun.f#L4705-L4715