Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.0.0 Prep #30

Merged
merged 30 commits into from
Jul 21, 2016
Merged

Version 1.0.0 Prep #30

merged 30 commits into from
Jul 21, 2016

Conversation

ryansanford
Copy link
Contributor

House keeping items to allow this repo to be more easily consumed by 3rd parties.

  • Standardize names of tools
  • Review all parameter names and functions
  • Address usability issues
  • Implement basic CI tests
  • Provide Dockerfile

Gunnar Schaefer and others added 30 commits June 29, 2016 14:00
Drop support for peripheral data
5ae4c6c
Remove destructive mode
7f47f16
Remove oneshot mode
5a8b05a
Invert existing data option
036388e
Bring (some) sanity to run loop
35bf282 
Must address lingering side effects.
A little more run loop sanity
b932f19
Fix path handling for unqualified local paths
0f365d6
Handle ctrl-c more gracefully
ff18e9c
Use acquisition UIDs instead of filenames for keys
04fdb20
Add dcmtk builing to travis
e7055f4
Add basic testing
ead3863
Expand testing capabilities
473e7d4
Add dummy upload server
d71d345
Clean up test infra
d450976 
closes #4, although unit tests are still outstanding
Rename dicom_net_reaper to dicom_reaper
2fd3214
Rename folder_uploader to folder_sniper
3b48f20
Update filenames to .TYPE.zip (from _)
34a7b95
Improve opt-in-related queries
7d6bf01
@ryansanford
Add Dockerfile and ignore files
655df5d
@ryansanford
Add ID field to DICOM query
2d2b7fe
@ryansanford
Add SCM info to docker image labels.
5a7f655
@ryansanford
Remove whitespace for pep8 compliance
26cec2b
@ryansanford
Add to description of --id-field option
73cda2f
@ryansanford
Clean out query template
f145a23
Update query tag handling
53340b4
Update map key and opt key param and var names
c43f921
Improve opt-related double query resilience
62abb3d
@ryansanford
Standardize location of Dockerfile
e97933f
Clarify opt-in matching behavior in help text
cc8d530
@ryansanford
Merge pull request #26 from scitran/docker-dev
27ef62a 
Add Dockerfile and supporting changes
@ryansanford ryansanford self-assigned this Jul 21, 2016
@ryansanford ryansanford merged commit 892cc02 into master Jul 21, 2016
@ryansanford ryansanford deleted the dev branch July 21, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryansanford ryansanford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryansanford @gsfr