Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] Test cleanup failure #476

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −26
Draft

[test-only] Test cleanup failure #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
955de02
Move test_run_binary_application to 'upstream' tests
phracek Feb 25, 2025
414a211
Always exit successfully from cleanup
hhorak Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/container-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

if: |
github.event.issue.pull_request
&& (contains(github.event.comment.body, '[test]') || contains(github.event.comment.body, '[test-all]'))
&& (contains(github.event.comment.body, '[test]') || contains(github.event.comment.body, '[test-upstream]') || contains(github.event.comment.body, '[test-all]'))
&& contains(fromJson('["OWNER", "MEMBER"]'), github.event.comment.author_association)
steps:
- uses: sclorg/tfaga-wrapper@main
Expand Down
1 change: 0 additions & 1 deletion test/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ test_init_wrapper_false_development
"

TEST_LIST_BINARY="\
test_run_binary_application
test_node_cmd_development_init_wrapper_true
"

Expand Down
1 change: 1 addition & 0 deletions test/run-upstream
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ test_client_cloudevents
test_client_fastify
test_client_pino
test_client_langchainjs
test_run_binary_application
"

readonly EXPRESS_REVISION="${EXPRESS_REVISION:-$(docker run --rm "${IMAGE_NAME}" -- npm show express version)}"
Expand Down
36 changes: 12 additions & 24 deletions test/test-lib-nodejs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,45 +522,32 @@ function test_dev_mode_true_development() {
}

function test_node_cmd_production_init_wrapper_false() {
if [ "$OS" != "rhel7" ]; then
# NODE_ENV=production INIT_WRAPPER=false NODE_CMD="node server.js"
test_node_cmd app production false "node server.js"
fi
test_node_cmd app production false "node server.js"
}

function test_node_cmd_development_init_wrapper_true() {
if [ "$OS" != "rhel7" ]; then
# NODE_ENV=development INIT_WRAPPER=true NODE_CMD="node server.js"
test_node_cmd app development true "node server.js"
fi
# NODE_ENV=development INIT_WRAPPER=true NODE_CMD="node server.js"
test_node_cmd app development true "node server.js"
}

function test_node_cmd_production_init_wrapper_true() {
if [ "$OS" != "rhel7" ]; then
# NODE_ENV=production INIT_WRAPPER=true NODE_CMD="node server.js"
test_node_cmd app production true "node server.js"
fi
# NODE_ENV=production INIT_WRAPPER=true NODE_CMD="node server.js"
test_node_cmd app production true "node server.js"
}

function test_node_cmd_development_init_wrapper_false() {
if [ "$OS" != "rhel7" ]; then
# NODE_ENV=development INIT_WRAPPER=false NODE_CMD="node server.js"
test_node_cmd app development false "node server.js"
fi
# NODE_ENV=development INIT_WRAPPER=false NODE_CMD="node server.js"
test_node_cmd app development false "node server.js"
}

function test_init_wrapper_true_development() {
if [ "$OS" != "rhel7" ]; then
# NODE_ENV=development INIT_WRAPPER=true
test_node_cmd app development true
fi
# NODE_ENV=development INIT_WRAPPER=true
test_node_cmd app development true
}

function test_init_wrapper_false_development() {
if [ "$OS" != "rhel7" ]; then
# NODE_ENV=development INIT_WRAPPER=true
test_node_cmd app development false
fi
# NODE_ENV=development INIT_WRAPPER=true
test_node_cmd app development false
}

function test_dev_mode_false_development() {
Expand Down Expand Up @@ -707,6 +694,7 @@ function cleanup() {
if image_exists ${IMAGE_NAME}-testapp; then
docker rmi -f ${IMAGE_NAME}-testapp
fi
return 0
}

# vim: set tabstop=2:shiftwidth=2:expandtab: