Don't cancel TF request when GHA Runner cancel the job 
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamacku
force-pushed
the
fix-cancel-issue
branch
from
a355e76
to
4508d00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 85.68% 90.27% +4.58%
==========================================
Files 10 10
Lines 503 545 +42
Branches 83 95 +12
==========================================
+ Hits 431 492 +61
+ Misses 70 52 -18
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. |
phracek
reviewed
Aug 1, 2024
phracek
requested changes
Aug 1, 2024
jamacku
force-pushed
the
fix-cancel-issue
branch
from
fc312d0
to
ebd0b8b
Compare
Public GitHub Actions Runner has limit of 6 hours for job execution time. > **Job execution time** - Each job in a workflow can run for up to 6 hours of execution time. If a job reaches this limit, the job is terminated and fails to complete. https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits Let's try to detect this instances and don't cancel the TF requests to allow users to inspect the results later.
jamacku
force-pushed
the
fix-cancel-issue
branch
from
ebd0b8b
to
089fe94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public GitHub Actions Runner has a limit of 6 hours for job execution time.
https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits
Let's try to detect these instances and avoid canceling the TF requests to allow users to inspect the results later.