Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated and working version of development dockerfile for Bassa UI #782

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Updated and working version of development dockerfile for Bassa UI #782

merged 4 commits into from
Aug 7, 2019

Conversation

kmehant
Copy link
Collaborator

@kmehant kmehant commented May 21, 2019

Description

Presently the development Dockerfile for Bassa UI is not properly written. We need a working dev Dockerfile so that it satisfies the docker-compose and goes along with other components for local development.

Related Issue

#781

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmehant kmehant added bug GSoC-2019 Tasks for GSoC-2019 labels May 21, 2019
@kmehant kmehant self-assigned this May 21, 2019
JaDogg
JaDogg reviewed May 23, 2019
View reviewed changes
ui/Dockerfile.dev Outdated Show resolved Hide resolved
@kmehant kmehant requested a review from JaDogg May 23, 2019 15:41
vivonk
vivonk requested changes May 26, 2019
View reviewed changes
Copy link
Collaborator

@vivonk vivonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments above else LGTM :)

@vivonk vivonk mentioned this pull request May 26, 2019
Closed
8 tasks
@kmehant kmehant requested a review from vivonk May 27, 2019 03:46
@kmehant kmehant mentioned this pull request Jun 2, 2019
Merged
8 tasks
vivonk
vivonk previously approved these changes Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@vivonk vivonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JaDogg
JaDogg reviewed Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@JaDogg JaDogg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me. But would be good if we can just use node:version like base image.

ui/Dockerfile.dev Outdated Show resolved Hide resolved
@kmehant
Copy link
Collaborator Author

kmehant commented Jul 1, 2019 •
edited
Loading

Seems OK to me. But would be good if we can just use node:version like base image.

@JaDogg bro I addressed your's and @agentmilindu bro's changes here.
Please review!

@kmehant kmehant requested review from vivonk and JaDogg July 1, 2019 14:06
@JaDogg JaDogg self-requested a review July 1, 2019 17:28
vivonk
vivonk approved these changes Jul 2, 2019
View reviewed changes
Copy link
Collaborator

@vivonk vivonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivonk vivonk merged commit 2c5724d into scorelab:develop Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivonk vivonk vivonk approved these changes

@JaDogg JaDogg JaDogg approved these changes

@charithccmc charithccmc Awaiting requested review from charithccmc

@agentmilindu agentmilindu Awaiting requested review from agentmilindu

Assignees

@kmehant kmehant

Labels
bug GSoC-2019 Tasks for GSoC-2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmehant @JaDogg @agentmilindu @vivonk