Feature/proxy support

[michael-harrison]

Support for setting of proxy url for web service client
Removal of duplicate key in hash produced by Holding.to_h
Added testing on 2.2.x

[coveralls]

Coverage decreased (-0.06%) to 99.685% when pulling 156c2da on michael-harrison:feature/proxy_support into 79fefd8 on scotdalton:master.

[coveralls]

Coverage decreased (-0.06%) to 99.685% when pulling 41232a7 on michael-harrison:feature/proxy_support into 79fefd8 on scotdalton:master.

[barnabyalter]

@michael-harrison Could you explain the proxy_url use to me? It looks like you're just sending a proxy into the Savon client. Can you document (on the README if appropriate) how and why we would use this in the exlibris-primo gem?

Also please try and get these passing on travis. I will try and get @scotdalton to give me access to update on rubygems.

Also is the savon upgrade a breaking change in any way? Or are you confident we can keep this in the 1.1.x release?

[coveralls]

Coverage decreased (-0.06%) to 99.685% when pulling 3182a1a on michael-harrison:feature/proxy_support into 79fefd8 on scotdalton:master.

[coveralls]

Coverage decreased (-0.06%) to 99.685% when pulling 7df73ed on michael-harrison:feature/proxy_support into 79fefd8 on scotdalton:master.

[coveralls]

Coverage decreased (-0.06%) to 99.685% when pulling 7df73ed on michael-harrison:feature/proxy_support into 79fefd8 on scotdalton:master.

[scotdalton]

@michael-harrison, @barnabyalter, sorry I've been MIA. Working towards making @barnabyalter a gem owner now.

[michael-harrison]

@barnabyalter Been doing a bit of work towards the doco and fixing the build.

Ruby Versions for Travis CI

With regard to the build what versions of Ruby do you want to support? I've had a quick look over the common implementations (MRI, JRuby and Rubinius) and think the following seems reasonable:

JRuby

• 1.7.x
• 9010

MRI

• 2.1.10 (EOL is soon)
• 2.2.7 (Going into Security Fix only for 1 year then EOL)
• 2.3.4
• 2.4.1

Rubinius
There are no explicit support docs but 3.x seems to be the current supported version. At this stage I've not been able to get Travis CI to build with rubinius at all.

• 3.x

Why have a proxy?

The reasoning for the proxy support was for the fixed IP restrictions used by some institutions to provide another (somewhat questionable) layer of security. Our application is host on AWS. We use an Elastic Load Balancer in combination with auto balancing & Route53 so we don't have a fixed IP address. To solve the issue we had to setup a specific EC2 instance with a fixed IP Address to use as a proxy server. So hence the need to specify the proxy server so savon can make the appropriate calls. In a nutshell if your hosting server doesn't have a fixed IP Address then you have to use this option.

[barnabyalter]

@michael-harrison forked and tracking NYULibraries#3

We just upgraded nokogiri because of a recent security vulnerability which broke support for Ruby 1.9.3 which 1.x still technically supported so we released 2.0 on rubygems. Both of your changes look good to me and we'll try and get them merged and pushed up after we resolve Travis ruby versions. jruby1.7 is ruby 1.9.3 so thats out; frankly rubinius is a pain in the ass; 2.4 actually requires changes to work so won't be included in this release.

[michael-harrison]

@barnabyalter I'm with you on Rubinius and jruby1.7 is hard work given the latest security vulnerability with nokogiri. However we do face a problem with Savon which I put a PR in for: savonrb/savon#803. I'm hoping they come back soon.

[michael-harrison]

@barnabyalter quick update. It's been very silent at the Savon camp. Seems like the maintainer is MIA. I'm resorting to using my forked master to address the Nokogiri / libxml2 security issue. As for a way forward I'm not really sure. Let me know if you have any ideas.

[michael-harrison]

@barnabyalter Quick update. Good news, the nokogiri update for Savon has been merged savonrb/savon#803. It's targeted for release with Savon 2.11.2

[barnabyalter]

@michael-harrison The latest exlibris-primo has '~> 2.11.1' requirement for savon so you should be able to locally update to 2.11.2