Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong name signing and more #126

Closed
wants to merge 9 commits into from
Closed

Conversation

spreedated
Copy link

Adressing #88

  • Swtiched to net6, since it's LTS and 5.0 is no longer supported
  • The projects are now strong named.
  • Fixed error of index out of bounds when InputStream was null (including fallback), on extension ParseFormUrlEncodedData()
  • Added mocking to unitests
  • Added several test on methods I altered
  • linted a lot of code, used LINQ on many parts, made public members to properties, from originally fields, used null checks when some code paths may get into null object to prevent null-ref-exception, etc.

Note: I'm not used to xunit nor shoudly, I prefer nunit - so feel free to rewrite the tests to conform the pattern.

@scottoffen
Copy link
Owner

These look great so far. I'd like to continue to target 5.0 in this version for those that have not yet upgraded. I'll remove that when I update the major version to 6.0.

@spreedated
Copy link
Author

You can still do a legacy support by simply adding net 5.0 to the FrameWorks tag:

From:
<TargetFrameworks>netstandard2.0;netstandard2.1;net6.0</TargetFrameworks>

To:
<TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net5.0</TargetFrameworks>

@scottoffen
Copy link
Owner

scottoffen commented Aug 23, 2022

I appreciate your desire to contribute! Please refer to the contribution guidelines, specifically the item:

  • Pull Requests Make sure all of your commits are atomic (one feature per commit)

I'd like to add some of the changes, but not others, and having everything wrapped up in this PR as an all-or-nothing approach leaves me no option to only allow some of the changes. Feel free to resubmit each change or group of changes as an atomic PR.

@scottoffen scottoffen closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants