chore: update Python version #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
reviewed
Oct 23, 2024
dateparser/date_parser.py
Outdated
| if hasattr(stz, "localize") and sys.version_info < (3, 6): | ||
| if hasattr(stz, "localize") and sys.version_info < (3, 9): |
There was a problem hiding this comment.
Actually this is always False now, so this whole block can be removed. There may be other such places in the code so I suggest looking for them and cleaning them up, as a separate PR.
wRAR
reviewed
Oct 23, 2024
.github/workflows/main.yml
Outdated
| env: | ||
| TOXENV: twinecheck | ||
| - python-version: "3.11" # Keep in sync with tox.ini | ||
| - python-version: "3.13" # Keep in sync with tox.ini |
There was a problem hiding this comment.
Not sure why does this mention tox.ini as we usually need to sync this with .readthedocs.yml (which wasn't changed in this PR, but we currently can't use 3.13 to build docs as RTD doesn't support that yet, so the docs Python version should be bumped only to 3.12.
|
Besides the test failures, it looks like all non-test envs (flake8, twinecheck, docs) run |
wRAR
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.