-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a standalone build of GUI and configure TS support #25
Provide a standalone build of GUI and configure TS support #25
Conversation
The build fails as this PR depends on changes from scratchfoundation/scratch-webpack-configuration#54 which are not in NPM yet |
I realized I hadn't configured eslint to check TS files and corrected that. @cwillisf does everything in scratch-webpack-configuration and here looks ok to you? Do we push the buttons? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Merge (both) when ready :)
scratch-gui.js
) as they weren't used by scratch-www anywayI haven't tested the build with scratch-www @MiroslavDionisiev what's the simplest way to do that? Want to make sure the externals were not actually used from scratch-www.
I will make some changes to abstract away project loading soon, but that would probably be a separate PR