98 Fixed linting issues due to unused variable or properties as found…

… by detekt
scribe-org · Sep 19, 2024 · 3fa06db · 3fa06db
1 parent 124e649
commit 3fa06db
Show file tree

Hide file tree

Showing 14 changed files with 10 additions and 34 deletions.
diff --git a/app/src/main/java/be/scri/fragments/AboutFragment.kt b/app/src/main/java/be/scri/fragments/AboutFragment.kt
@@ -16,11 +16,10 @@ import be.scri.helpers.CustomAdapter
 import be.scri.models.ItemsViewModel
 
 class AboutFragment : Fragment() {
-    private var appName = ""
-    private var primaryColor = 0
+
 
     private lateinit var binding: FragmentAboutBinding
-    private lateinit var gestureDetector: GestureDetector
+
 
     override fun onCreateView(
         inflater: LayoutInflater,
@@ -219,10 +218,5 @@ class AboutFragment : Fragment() {
         fragmentTransaction.commit()
     }
 
-    companion object {
-        private const val EASTER_EGG_TIME_LIMIT = 3000L
-        private const val EASTER_EGG_REQUIRED_CLICKS = 7
-        private const val SWIPE_THRESHOLD = 100
-        private const val SWIPE_VELOCITY_THRESHOLD = 100
-    }
+
 }
diff --git a/app/src/main/java/be/scri/helpers/String.kt b/app/src/main/java/be/scri/helpers/String.kt
@@ -2,8 +2,6 @@ package be.scri.helpers
 
 operator fun String.times(x: Int): String {
     val stringBuilder = StringBuilder()
-    for (i in 1..x) {
-        stringBuilder.append(this)
-    }
+    (1..x).forEach { stringBuilder.append(this) }
     return stringBuilder.toString()
 }
diff --git a/app/src/main/java/be/scri/services/EnglishKeyboardIME.kt b/app/src/main/java/be/scri/services/EnglishKeyboardIME.kt
@@ -44,7 +44,6 @@ class EnglishKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
 
     override fun onInitializeInterface() {
         super.onInitializeInterface()

diff --git a/app/src/main/java/be/scri/services/FrenchKeyboardIME.kt b/app/src/main/java/be/scri/services/FrenchKeyboardIME.kt
@@ -14,8 +14,7 @@ import be.scri.views.MyKeyboardView
 class FrenchKeyboardIME : SimpleKeyboardIME() {
     override fun getKeyboardLayoutXML(): Int = R.xml.keys_letters_french
 
-    private var lastSpaceTime: Long = 0
-    private val doubleTapThreshold: Long = 300
+
 
     enum class ScribeState {
         IDLE,
@@ -32,7 +31,6 @@ class FrenchKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
     override lateinit var binding: KeyboardViewCommandOptionsBinding
     override var keyboardView: MyKeyboardView? = null
     override var keyboard: MyKeyboard? = null

diff --git a/app/src/main/java/be/scri/services/GermanKeyboardIME.kt b/app/src/main/java/be/scri/services/GermanKeyboardIME.kt
@@ -29,7 +29,6 @@ class GermanKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
     override lateinit var binding: KeyboardViewCommandOptionsBinding
     override var keyboardView: MyKeyboardView? = null
     override var keyboard: MyKeyboard? = null
@@ -49,8 +48,7 @@ class GermanKeyboardIME : SimpleKeyboardIME() {
         keyboard = MyKeyboard(this, getKeyboardLayoutXML(), enterKeyType)
     }
 
-    private var lastSpaceTime: Long = 0
-    private val doubleTapThreshold: Long = 300
+
 
     private fun shouldCommitPeriodAfterSpace(language: String): Boolean {
         val sharedPref = getSharedPreferences("app_preferences", Context.MODE_PRIVATE)

diff --git a/app/src/main/java/be/scri/services/ItalianKeyboardIME.kt b/app/src/main/java/be/scri/services/ItalianKeyboardIME.kt
@@ -29,7 +29,6 @@ class ItalianKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
     override lateinit var binding: KeyboardViewCommandOptionsBinding
     override var keyboardView: MyKeyboardView? = null
     override var keyboard: MyKeyboard? = null
@@ -49,8 +48,6 @@ class ItalianKeyboardIME : SimpleKeyboardIME() {
         keyboard = MyKeyboard(this, getKeyboardLayoutXML(), enterKeyType)
     }
 
-    private var lastSpaceTime: Long = 0
-    private val doubleTapThreshold: Long = 300
 
     private fun shouldCommitPeriodAfterSpace(language: String): Boolean {
         val sharedPref = getSharedPreferences("app_preferences", Context.MODE_PRIVATE)

diff --git a/app/src/main/java/be/scri/services/PortugueseKeyboardIME.kt b/app/src/main/java/be/scri/services/PortugueseKeyboardIME.kt
@@ -29,7 +29,6 @@ class PortugueseKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
     override lateinit var binding: KeyboardViewCommandOptionsBinding
     override var keyboardView: MyKeyboardView? = null
     override var keyboard: MyKeyboard? = null
@@ -49,8 +48,7 @@ class PortugueseKeyboardIME : SimpleKeyboardIME() {
         keyboard = MyKeyboard(this, getKeyboardLayoutXML(), enterKeyType)
     }
 
-    private var lastSpaceTime: Long = 0
-    private val doubleTapThreshold: Long = 300
+
 
     private fun shouldCommitPeriodAfterSpace(language: String): Boolean {
         val sharedPref = getSharedPreferences("app_preferences", Context.MODE_PRIVATE)

diff --git a/app/src/main/java/be/scri/services/RussianKeyboardIME.kt b/app/src/main/java/be/scri/services/RussianKeyboardIME.kt
@@ -29,7 +29,6 @@ class RussianKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
     override lateinit var binding: KeyboardViewCommandOptionsBinding
     override var keyboardView: MyKeyboardView? = null
     override var keyboard: MyKeyboard? = null
@@ -49,8 +48,6 @@ class RussianKeyboardIME : SimpleKeyboardIME() {
         keyboard = MyKeyboard(this, getKeyboardLayoutXML(), enterKeyType)
     }
 
-    private var lastSpaceTime: Long = 0
-    private val doubleTapThreshold: Long = 300
 
     private fun shouldCommitPeriodAfterSpace(language: String): Boolean {
         val sharedPref = getSharedPreferences("app_preferences", Context.MODE_PRIVATE)

diff --git a/app/src/main/java/be/scri/services/SpanishKeyboardIME.kt b/app/src/main/java/be/scri/services/SpanishKeyboardIME.kt
@@ -29,7 +29,6 @@ class SpanishKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
     override lateinit var binding: KeyboardViewCommandOptionsBinding
     override var keyboardView: MyKeyboardView? = null
     override var keyboard: MyKeyboard? = null

diff --git a/app/src/main/java/be/scri/services/SwedishKeyboardIME.kt b/app/src/main/java/be/scri/services/SwedishKeyboardIME.kt
@@ -29,7 +29,6 @@ class SwedishKeyboardIME : SimpleKeyboardIME() {
 
     private var currentState: ScribeState = ScribeState.IDLE
     private lateinit var keyboardBinding: KeyboardViewKeyboardBinding
-    private lateinit var commandBinding: KeyboardViewCommandOptionsBinding
     override lateinit var binding: KeyboardViewCommandOptionsBinding
     override var keyboardView: MyKeyboardView? = null
     override var keyboard: MyKeyboard? = null

diff --git a/app/src/main/java/be/scri/views/MyKeyboardView.kt b/app/src/main/java/be/scri/views/MyKeyboardView.kt
@@ -506,7 +506,6 @@ class MyKeyboardView
             val currentNightMode = context.resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK
             val isSystemDarkMode = currentNightMode == Configuration.UI_MODE_NIGHT_YES
             val isUserDarkMode = sharedPref.getBoolean("dark_mode", isSystemDarkMode)
-            val changeKeyColor = sharedPref.getBoolean("pref_key_change_key_color", false)
             val keyBackgroundColor =
                 if (isUserDarkMode) {
                     Color.DKGRAY

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -11,7 +11,7 @@ buildscript {
     }
 
     dependencies {
-        classpath("com.android.tools.build:gradle:8.6.0")
+        classpath("com.android.tools.build:gradle:8.2.2")
         classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version")
         classpath("io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.23.6")
         classpath("org.jlleitschuh.gradle:ktlint-gradle:12.1.1")

diff --git a/detekt.yml b/detekt.yml
@@ -10,7 +10,7 @@ style:
     ReturnCount:
         active: false
     UnusedPrivateProperty:
-        active: false
+        active: true
     UnusedParameter:
         active: false
     FunctionOnlyReturningConstant:

diff --git a/gradle.properties b/gradle.properties
@@ -3,4 +3,4 @@ android.nonFinalResIds=false
 android.nonTransitiveRClass=false
 android.useAndroidX=true
 org.gradle.jvmargs=-Xmx4g -Xms1g
-
+org.gradle.java.home=C:/Program Files/Android/Android Studio/jbr