Add suppressions (#202)

* Add suppressions This commit will add suppressions for "Long method" * Remove enabled detekt methods from yaml file * Revert detekt changes * Add Suppress to LanguageSettingsFragment.kt This commit will add a suppress for long methods in LanguageSettingsFragment.kt --------- Co-authored-by: Andrew Tavis McAllister <[email protected]>
scribe-org · Oct 17, 2024 · 43ec2d7 · 43ec2d7
1 parent 7b57538
commit 43ec2d7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/app/src/main/java/be/scri/fragments/LanguageSettingsFragment.kt b/app/src/main/java/be/scri/fragments/LanguageSettingsFragment.kt
@@ -19,6 +19,7 @@ import be.scri.databinding.FragmentLanguageSettingsBinding
 import be.scri.helpers.CustomAdapter
 import be.scri.models.SwitchItem
 
+@Suppress("LongMethod")
 class LanguageSettingsFragment : Fragment() {
     private var _binding: FragmentLanguageSettingsBinding? = null
     val binding get() = _binding!!

diff --git a/app/src/main/java/be/scri/helpers/MyKeyboard.kt b/app/src/main/java/be/scri/helpers/MyKeyboard.kt
@@ -21,6 +21,7 @@ import java.io.IOException
  * @attr ref android.R.styleable#Keyboard_keyWidth
  * @attr ref android.R.styleable#Keyboard_horizontalGap
  */
+@Suppress("LongMethod")
 class MyKeyboard {
     /** Horizontal gap default for all rows  */
     private var mDefaultHorizontalGap = 0

diff --git a/app/src/main/java/be/scri/views/MyKeyboardView.kt b/app/src/main/java/be/scri/views/MyKeyboardView.kt
@@ -58,7 +58,7 @@ import java.util.Arrays
 import java.util.Locale
 
 @SuppressLint("UseCompatLoadingForDrawables")
-@Suppress("LargeClass")
+@Suppress("LargeClass", "LongMethod")
 class MyKeyboardView
     @JvmOverloads
     constructor(

diff --git a/detekt.yml b/detekt.yml
@@ -9,10 +9,10 @@ style:
         active: false
     ReturnCount:
         active: false
-    # UnusedPrivateProperty:
-    #     active: true
-    # UnusedParameter:
-    #     active: true
+    UnusedPrivateProperty:
+        active: true
+    UnusedParameter:
+        active: true
     UtilityClassWithPublicConstructor:
         active: false
 
@@ -26,7 +26,7 @@ complexity:
     LongParameterList:
         active: false
     LongMethod:
-        active: false
+        active: true
     CyclomaticComplexMethod:
         active: false
 
@@ -39,8 +39,8 @@ exceptions:
 empty-blocks:
     EmptyCatchBlock:
         active: false
-    # EmptyFunctionBlock:
-    #     active: false
+    EmptyFunctionBlock:
+        active: false
 
 performance:
     SpreadOperator: