Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App UI to a tab bar #40

Closed
2 tasks done
andrewtavis opened this issue Jul 11, 2024 · 8 comments
Closed
2 tasks done

Update App UI to a tab bar #40

andrewtavis opened this issue Jul 11, 2024 · 8 comments
Assignees
Labels
feature New feature or request

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jul 11, 2024

Terms

Description

This issue would convert over the Scribe-Android app UI to use a tab bar at the bottom of the screen. The basis of this can be seen in the designs on Figma where the application has Installation, Settings, and About tabs.

What this issue would entail is:

  • An installation tab with the current home app screen
  • A settings tab with any keyboard related settings
    • This does not need to be based on keyboards now!
    • Let's start with settings for all keyboards and switch to per keyboard settings at a later time
  • An about tab with any contact information from the application

From here we will make more issues on expanding out the various pages of the application! 🚀

Contribution

Happy to support as I can and review. Making this issue for @angrezichatterbox via discussions in #39 😊

@angrezichatterbox
Copy link
Member

I would start working on this issue. :)

@andrewtavis
Copy link
Member Author

Thank you, @angrezichatterbox! Really excited to see this progress :) :)

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Jul 15, 2024

Screenshot 2024-07-15 at 10 29 31 AM Screenshot 2024-07-15 at 10 26 20 AM

This is how the navbar looks for the dark and light modes respectively, Is there any change that you would like before I make a PR
I am sorry it took longer than usual. I had some personal work to do.

@andrewtavis
Copy link
Member Author

No stress, @angrezichatterbox! Is looking good to me 😊 We should make further issues for coloration and such, but that can be later :) Quick check on this that I'm realizing I forgot to mention: Is the tab bar able to be swiped? If so, then I think we're good to go! Would be nice to have that, but if not we could also do another issue for that :)

@angrezichatterbox
Copy link
Member

I have added the swipeGesture for changing the tabs. I will make a PR.

@angrezichatterbox
Copy link
Member

I have made the PR, is there any other issue you would like me to work on?

@andrewtavis
Copy link
Member Author

Thanks for this, @angrezichatterbox! Give me a moment to bring the current two PRs in and then we can make some more :) Will try to review this weekend or early next week, and maybe we can do a call after?

@andrewtavis
Copy link
Member Author

Closed by #41 🚀 Thank you for your dedication, @angrezichatterbox! Really amazing how quickly you've been able to figure out all of this 😊

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants