-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Added separate keyboard selection for all languages #39
feat:Added separate keyboard selection for all languages #39
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Thanks so much for this, @angrezichatterbox! Really looking forward to the review 😊 It'll likely be a few days before I have time to check it as I'm in the US seeing friends. If you want I can make the issue for the tabs for you really quick so you can work on that too, but I will get to this when I can :) |
Ya sure I would work on the other issue once its created . |
Created #40 for this, @angrezichatterbox :) Let me know if there are any questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really is a thing of beauty, @angrezichatterbox 😊 Sorry that the review took so long, and thank you so much for the amazing work here! Looking forward to the next review! 🚀
1e07813 Merge pull request scribe-org#42 from angrezichatterbox/XML-TO-JSON-FIX 2a8fe2a fix:Added escape characters for \n 924f00c scribe-org#37 minor edits to conversion scripts and try new command path aafa0f6 scribe-org#37 update Scribe-i18n structure and fix conversion workflow 6a8faaa Merge pull request scribe-org#39 from Jag-Marcel/i18n-refactor 2b9caff Added newline at end of all JSON files e775e46 Updated jsons and xcstrings file using new iOS scripts dd018c1 Refactored iOS conversion scripts to use python json package 7f8c273 Updated conversion workflow to use paths filter instead of conditional check ff21cdb Refactored scripts into new iOS and Android folders git-subtree-dir: app/src/main/assets/i18n git-subtree-split: 1e07813b694edc57934b46ec76943cc1e974d4fb
Description
This pull request aims to make separate keyboard selection for separate languages into individual keyboards. Through this pull request the user could enable the keyboard that the user wants from the android settings and then when the user selected the keyboard from the input method picker.
Related issue