Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wikimedia and Scribe page to About tab #52

Closed
2 tasks done
andrewtavis opened this issue Aug 3, 2024 · 4 comments
Closed
2 tasks done

Add Wikimedia and Scribe page to About tab #52

andrewtavis opened this issue Aug 3, 2024 · 4 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Aug 3, 2024

Terms

Description

This issue would add the Wikimedia and Scribe page to the About tab of the Scribe-Android application :) The designs for it can be found here, with an image of the page being found below:

Wikimedia and Scribe - Light

We'll need to include the logos for Wikidata and Wikipedia, as well as make sure that the back button for sub-pages is functioning correctly.

Contribution

@angrezichatterbox expressed interest in working on this one 😊 Happy to review and support as I can!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Aug 3, 2024
@angrezichatterbox
Copy link
Member

So currently there is an action bar at the top for the Scribe-Android. Would it be removed at some point to make the app similar to Scribe-iOS?If so should I consider that and make the Wikimedia and Scribe Text not on the action bar or should I put it on the action bar for now?

@andrewtavis
Copy link
Member Author

Maybe it's ok to leave it, @angrezichatterbox? We have a top header for Scribe-iOS as well that will function similar to an action bar. That also has a light shadow under it on scroll, so I think if we just blend the action bar in it's basically the same?

@angrezichatterbox
Copy link
Member

I have created a pull request for this. I haven't customized the action bar for the page since it would be better if that were done universally for all pages together. Please do give suggestions for any changes to be made to the page. :)

@andrewtavis
Copy link
Member Author

Closed via #54 🎉 So much progress, @angrezichatterbox! Really is starting to take shape, and it was super great to be able to tell the Wikidata Lexeme community that there's been so much progress here! Thanks so much :)

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants