-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Wikimedia and Scribe Page #54
Implements Wikimedia and Scribe Page #54
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Hey @angrezichatterbox 👋 I've set up a new device at this point and it's telling me that the Gradle settings are out of date, so I can't build the app. Would we be able to upgrade the Gradle settings as a part of this, and then hopefully I'll be able to review? |
Ya, I will upgrade the Gradle and push the changes. |
I have updated the Gradle version. I have to upgrade some dependencies along with it. Due to this, I had to make layout changes to the About activity and the Wikimedia Scribe page I had just created. |
Thanks for all the effort here, @angrezichatterbox! 🏆 |
Will get to the review soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the quick reaction and update so the review was easier, @angrezichatterbox! Really appreciate it 😊 All is looking wonderful here! Maybe we want to think about bringing in Scribe-i18n soon so that it's easier to get the needed texts for the application? I'll ping you in that issue 😇
Contributor checklist
Description
Related issue