Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Wikimedia and Scribe Page #54

Merged

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

  • The pull request implements the Wikimedia Scribe page. The page can be accessed from the About page by clicking on the option Wikimedia and Scribe.

Related issue

Copy link

github-actions bot commented Aug 7, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review August 7, 2024 20:15
@andrewtavis
Copy link
Member

Hey @angrezichatterbox 👋 I've set up a new device at this point and it's telling me that the Gradle settings are out of date, so I can't build the app. Would we be able to upgrade the Gradle settings as a part of this, and then hopefully I'll be able to review?

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Aug 8, 2024

Hey @angrezichatterbox 👋 I've set up a new device at this point and it's telling me that the Gradle settings are out of date, so I can't build the app. Would we be able to upgrade the Gradle settings as a part of this, and then hopefully I'll be able to review?

Ya, I will upgrade the Gradle and push the changes.

@angrezichatterbox
Copy link
Member Author

I have updated the Gradle version. I have to upgrade some dependencies along with it. Due to this, I had to make layout changes to the About activity and the Wikimedia Scribe page I had just created.

@andrewtavis
Copy link
Member

Thanks for all the effort here, @angrezichatterbox! 🏆

@andrewtavis
Copy link
Member

Will get to the review soon :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the quick reaction and update so the review was easier, @angrezichatterbox! Really appreciate it 😊 All is looking wonderful here! Maybe we want to think about bringing in Scribe-i18n soon so that it's easier to get the needed texts for the application? I'll ping you in that issue 😇

@andrewtavis andrewtavis merged commit 5991cf6 into scribe-org:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants