Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference all strings from scribe i18n #105

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

  • The PR adds reference to all strings from Scribe-i18n for Scribe-Android

Related issue

Additional information

  • I ran the script update_i18n_keys.sh for updating the keys. I hope I would not have caused any mess-ups in the git subtree.
  • The strings used in the user interfaces of Scribe-Android to be added to Scribe-i18n are:

"Show a popup on keypress",
"Dark mode"
“Enable Keyboard”
The Scribe developers (SCRIBE) built the Android application "Scribe - Language Keyboards" (SERVICE) using third party code. All source code used in the creation of this SERVICE comes from sources that allow its full use in the manner done so by the SERVICE. This section lists the source code on which the SERVICE was based as well as the coinciding licenses of each.\n\nThe following is a list of all used source code, the main author or authors of the code, the license under which it was released at time of usage, and a link to the license.\n\n1. Simple Keyboard\n• Author:Simple Mobile Tools\n• License: GPL-3.0\n• Link: https://github.com/SimpleMobileTools/Simple-Keyboard/blob/main/LICENSE</string>

c0a45c2 Merge pull request scribe-org#46 from angrezichatterbox/Run-Json-to-XML-Scripts
3af18ab feat:Ran the script for converting json to xml
935903a Edit working directory for conversion workflows to try to fix error
c60a196 Merge pull request scribe-org#45 from weblate/weblate-scribe-scribe-i18n
fc18213 Translated using Weblate (Spanish)
872d232 Set working directory for conversion scripts
2f6f5ab Fix incorrect keys in translation language JSONs
feb4a18 Edit to conversion scripts to fix their paths with relation to root
d6cce32 Fix German GitHub key
c26c78d Add all app texts for scribe + conjugate with new keys
ad588cc Update the suggested room based on new room name

git-subtree-dir: app/src/main/assets/i18n
git-subtree-split: c0a45c2dfbf2519007056ce4e23b3051e5992171
Copy link

github-actions bot commented Sep 12, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks @angrezichatterbox! I'll add the other strings this evening and bring this in :)

@andrewtavis
Copy link
Member

"Enable keyboard" won't be added to the strings, by the way. We'll make an issue soon to expand the directions with keys I already added.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @angrezichatterbox! I'll do the other strings now and then we can do one more PR to close out the issue :)

@andrewtavis andrewtavis merged commit 4e4e57f into scribe-org:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants