Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Implemented Install Keyboard Page #163

Merged

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist

Description

The PR implements the Install Keyboards for the settings page during the first install for the user. On Selection of the keyboard language select language settings for the individual settings shows up.

Related issue

Copy link

github-actions bot commented Oct 1, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 1, 2024 15:43
@andrewtavis
Copy link
Member

Quick notes on this PR, @angrezichatterbox:

  • Is it possible to remove the message forcing users to install a keyboard?
    • So I mean "Thanks for downloading Scribe! Please enable keyboards on the next screen and press 'Back' when finished."
  • The install keyboards button on Settings when a keyboard isn't installed isn't showing up in dark mode

We'll be ready to merge after both of these! Thanks for the efforts so far!

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Oct 2, 2024

Quick notes on this PR, @angrezichatterbox:

  • Is it possible to remove the message forcing users to install a keyboard?

    • So I mean "Thanks for downloading Scribe! Please enable keyboards on the next screen and press 'Back' when finished."
  • The install keyboards button on Settings when a keyboard isn't installed isn't showing up in dark mode

We'll be ready to merge after both of these! Thanks for the efforts so far!

I will remove the message forcing users to install the keyboard. As for the install keyboards button not showing in the dark mode I’m not entirely certain about that issue. For me, the button is visible in dark mode. Could you clarify if you meant something different? Thank you!

Screenshot 2024-10-02 at 9 42 02 AM

Also, I just observed now I should make it a sentence case rather than being capital.

@angrezichatterbox
Copy link
Member Author

I have added the changes to make the Install keyboard text not be in all caps and removed new users being forced to install the keyboards.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working wonderfully, @angrezichatterbox! Thanks for this :) :) Nice to have the initial interactions of the user a bit more set 😊

@andrewtavis andrewtavis merged commit 99d6c5c into scribe-org:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants