-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Implemented Install Keyboard Page #163
feat:Implemented Install Keyboard Page #163
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Quick notes on this PR, @angrezichatterbox:
We'll be ready to merge after both of these! Thanks for the efforts so far! |
I will remove the message forcing users to install the keyboard. As for the install keyboards button not showing in the dark mode I’m not entirely certain about that issue. For me, the button is visible in dark mode. Could you clarify if you meant something different? Thank you! Also, I just observed now I should make it a sentence case rather than being capital. |
I have added the changes to make the Install keyboard text not be in all caps and removed new users being forced to install the keyboards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working wonderfully, @angrezichatterbox! Thanks for this :) :) Nice to have the initial interactions of the user a bit more set 😊
Contributor checklist
Description
The PR implements the Install Keyboards for the settings page during the first install for the user. On Selection of the keyboard language select language settings for the individual settings shows up.
Related issue