-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version output to AboutFragment #169
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
@@ -27,7 +27,7 @@ | |||
<string name="app.about.feedback.rate_conjugate">Rate Scribe Conjugate</string> | |||
<string name="app.about.feedback.rate_scribe">Rate Scribe</string> | |||
<string name="app.about.feedback.title">Feedback and support</string> | |||
<string name="app.about.feedback.version">Version</string> | |||
<string name="app.about.feedback.version">Version %1$s</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be updated in Scribe-i18n repo also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeKaN Could you remove these changes for now where the assets folder values are being changed? It would mess up the git subtree. @andrewtavis Should we make the text for now be taken from strings.xml which Android has given by default until the string is changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the PR @DeKaN. Could u remove the changes from the assets and temporarily add the value to the strings.xml file only and then the PR would be perfect
@angrezichatterbox Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run the app ones so that changes to values-es would be retracted? Also, could you add the version string to strings.xml rather than string.xml? So it is like every time the app is run the values in string.xml files get changed.
Yes, Gradle overwrites string.xml by version from assets (that's why I added changes there). |
The reference remains the same you could call using R.string.name_of_string or @string/string_name. The value would get changed during the build if it's added to string.xml. For now, could u add it to strings.xml. Let the name be the same. |
Resources must have unique ids. So string with id |
I forgot that there was a Version string. For not just add a new string to strings.xml with the resource id of your choice and then use the string. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @DeKaN, and also for your two's collaboration 😊 Just tested and it's working fine. We can figure out the specifics of the text once we bring the Scribe-i18n subtree in next time :)
Contributor checklist
Description
Adds current version text to AboutFragment. Clicking on it opens Github Releases page. Version text is generated from property
android.defaultConfig.versionName
in build.gradle.ktsRelated issue