-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design: align settings header with content #171
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MostafaMohamed2002 Thank you for the PR. The changes you have made look great.Could you try correcting the margins in the case of the About page and the pages directed from the about page?
done 👌 , sorry for being late 😢
|
Not late at all, @MostafaMohamed2002! Thanks for the further contributions :) |
This looks awesome @MostafaMohamed2002. Could you adjust the padding for the settings page a bit So that it matches the recycler view and the titles present in the page. |
i don't clearly understand what you want 😢 |
Sorry I wasn't clear enough |
Sorry, your PR is fine. It was an issue with my simulator not showing the right padding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the great work here, @MostafaMohamed2002! Really grateful that you've already moved on to another issue as well 😊
Contributor checklist
Description
Related issue