Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: align settings header with content #171

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

MostafaMohamed2002
Copy link
Contributor

Contributor checklist


Description

  • Remove left margin from application page headers
before after
before image
before image

Related issue

Copy link

github-actions bot commented Oct 4, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Sorry, something went wrong.

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 4, 2024
Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostafaMohamed2002 Thank you for the PR. The changes you have made look great.Could you try correcting the margins in the case of the About page and the pages directed from the about page?

@MostafaMohamed2002
Copy link
Contributor Author

@MostafaMohamed2002 Thank you for the PR. The changes you have made look great.Could you try correcting the margins in the case of the About page and the pages directed from the about page?

done 👌 , sorry for being late 😢
check it out below 😊

Screenshot_1728308146 Screenshot_1728308159
Screenshot_1728308168 Screenshot_1728308179

@andrewtavis
Copy link
Member

Not late at all, @MostafaMohamed2002! Thanks for the further contributions :)

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Oct 7, 2024

This looks awesome @MostafaMohamed2002. Could you adjust the padding for the settings page a bit So that it matches the recycler view and the titles present in the page.

@MostafaMohamed2002
Copy link
Contributor Author

i don't clearly understand what you want 😢

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Oct 7, 2024

i don't clearly understand what you want 😢

Sorry I wasn't clear enough
What I wanted to say is that the elements of the page could have more padding. Like the recycler view can you make the padding similar to the about page recycler view?

@MostafaMohamed2002
Copy link
Contributor Author

i don't clearly understand what you want 😢

Sorry I wasn't clear enough What I wanted to say is that the elements of the page could have more padding. Like the recycler view can you make the padding similar to the about page recycler view?

i think that's what you want , am i right ?

before after
settings_page_before settings_page_after

@angrezichatterbox
Copy link
Member

Sorry, your PR is fine. It was an issue with my simulator not showing the right padding.
I think its good for merge :) . Thanks :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the great work here, @MostafaMohamed2002! Really grateful that you've already moved on to another issue as well 😊

@andrewtavis andrewtavis merged commit 758a3cb into scribe-org:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants